Skip to content

Fix issues and improve #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 19, 2022
Merged

Fix issues and improve #2

merged 8 commits into from
Feb 19, 2022

Conversation

Kacarott
Copy link
Collaborator

Originally the mode had a feature to highlight undefined terms as errors, making debugging easier. However it was overlooked that this breaks (incorrectly highlights) terms which are defined in preloaded, or in standalone code-snippets (eg. in kata descriptions).

  • Implement #debug to enable highlighting undefined terms and bare expressions
  • Remove default highlighting of undefined terms and bare expressions
  • Add error highlighting of tabs (spaces should be used)
  • Updated example

index.html Outdated
# Bare term
(\ f x . f (x x))

# Unbound
someFunc = \ local . true nonexistant local
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-existent ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kebab-case instead of camelCase applies in more places.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also be changed

@Kacarott Kacarott merged commit c004133 into codewars:main Feb 19, 2022
@Kacarott Kacarott deleted the dev branch February 19, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants